Skip to content

cluster: support tikv-worker#2677

Open
Lloyd-Pottiger wants to merge 2 commits intopingcap:masterfrom
Lloyd-Pottiger:cluster-tikv-worker
Open

cluster: support tikv-worker#2677
Lloyd-Pottiger wants to merge 2 commits intopingcap:masterfrom
Lloyd-Pottiger:cluster-tikv-worker

Conversation

@Lloyd-Pottiger
Copy link
Contributor

@Lloyd-Pottiger Lloyd-Pottiger commented Jan 21, 2026 •
edited
Loading

What problem does this PR solve?

close #xxx

What is changed and how it works?

Support tikv-worker in TiUP Cluster.

sudo ./tiup/bin/tiup-cluster deploy qy-columnar-test v8.5.4-nextgen.202510.0 ./topo/columnar.topo.yaml --ignore-config-check --yes

sudo ./tiup/bin/tiup-cluster patch qy-columnar-test cse-package/tidb-nightly-linux-amd64.tar.gz -R tidb --offline  --yes
sudo ./tiup/bin/tiup-cluster patch qy-columnar-test cse-package/tikv-nightly-linux-amd64.tar.gz -R tikv --offline  --yes
sudo ./tiup/bin/tiup-cluster patch qy-columnar-test cse-package/tiflash-nightly-linux-amd64.tar.gz -R tiflash --offline  --yes
sudo ./tiup/bin/tiup-cluster patch qy-columnar-test cse-package/pd-nightly-linux-amd64.tar.gz -R pd --offline  --yes
sudo ./tiup/bin/tiup-cluster patch qy-columnar-test cse-package/tikv-worker-nightly-linux-amd64.tar.gz -R tikv-worker --offline  --yes

sudo ./tiup/bin/tiup-cluster start qy-columnar-test --yes

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 21, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bb7133 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 21, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bb7133 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested a review from srstack January 21, 2026 06:52
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 21, 2026
@Lloyd-Pottiger Lloyd-Pottiger changed the title Cluster tikv worker cluster: support tikv-worker Jan 21, 2026
@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 6.66667% with 154 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.15%. Comparing base (7d025cb) to head (bfb04e6).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/cluster/spec/tikv_worker.go 6.36% 102 Missing and 1 partial ⚠️
pkg/cluster/template/scripts/tikv_worker.go 0.00% 12 Missing ⚠️
pkg/cluster/manager/patch.go 0.00% 10 Missing ⚠️
pkg/cluster/task/download.go 0.00% 9 Missing ⚠️
pkg/cluster/task/update_meta.go 0.00% 6 Missing ⚠️
pkg/cluster/spec/monitoring.go 0.00% 5 Missing ⚠️
pkg/cluster/task/copy_component.go 0.00% 5 Missing ⚠️
pkg/cluster/template/config/prometheus.go 0.00% 3 Missing ⚠️
pkg/cluster/spec/spec.go 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2677      +/-   ##
==========================================
- Coverage   42.30%   42.15%   -0.15%     
==========================================
  Files         424      426       +2     
  Lines       46888    47044     +156     
==========================================
- Hits        19834    19830       -4     
- Misses      24390    24546     +156     
- Partials     2664     2668       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Lloyd-Pottiger
Copy link
Contributor Author

Lloyd-Pottiger commented Jan 21, 2026

/cc @xhebox @breezewish

@ti-chi-bot ti-chi-bot bot requested review from breezewish and xhebox January 21, 2026 07:14
@xhebox
Copy link
Collaborator

xhebox commented Jan 21, 2026 •
edited
Loading 

  // For some repos (e.g. internal ones), tikv-worker can be packaged as anextra binary inside the `tikv` component. Prefer checking with  `bin/tikv-worker` when it exists, otherwise fall back to the component's default entry.

The comment is true. Isn't this break that behavior?

@Lloyd-Pottiger
Copy link
Contributor Author

Lloyd-Pottiger commented Jan 21, 2026 

  // For some repos (e.g. internal ones), tikv-worker can be packaged as anextra binary inside the `tikv` component. Prefer checking with  `bin/tikv-worker` when it exists, otherwise fall back to the component's default entry.

The comment is true. Isn't this break that behavior?

http://tiup.pingcap.net:8988/ tikv-worker is an independent package.

@Lloyd-Pottiger Lloyd-Pottiger marked this pull request as draft January 21, 2026 08:55
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 21, 2026
@Lloyd-Pottiger Lloyd-Pottiger marked this pull request as ready for review January 22, 2026 04:29
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 22, 2026
@ti-chi-bot ti-chi-bot bot requested a review from nexustar January 22, 2026 04:29
@Lloyd-Pottiger
work around
bfb04e6 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@xhebox
Copy link
Collaborator

xhebox commented Feb 4, 2026

The comment is true. Isn't this break that behavior?

http://tiup.pingcap.net:8988/ tikv-worker is an independent package.

It is. But in some old packages, it is not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srstack srstack Awaiting requested review from srstack

@breezewish breezewish Awaiting requested review from breezewish

@xhebox xhebox Awaiting requested review from xhebox

@nexustar nexustar Awaiting requested review from nexustar

Assignees

No one assigned

Labels

size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Lloyd-Pottiger @codecov-commenter @xhebox